-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Stop workshop elves and their workshop from spawning #78842
[Magiclysm] Stop workshop elves and their workshop from spawning #78842
Conversation
Use the |
There really is a flag for everything |
I'm not asking you to do this, because I've been pretty certain I could implement the fix you are suggesting we wait for, for the last six months, but it's gonna take time and energy and I keep deciding to spend that energy on something else. But we have the capability to make locations holiday only by creating an overmap special of the same size "strangely festive grassland" that spawns once globally unique. Then set a global EOC to run once daily, checking the date (in game currently, future state could look at external date) and during the week before and after the 25th of december it transforms like an unvitrified farm and post the season transforms back into a "strangely festive grassland".
Update the map with { "mapgen_update": [ "map_spawn_terrain", "map_spawn_furniture", "map_spawn_trap", "map_spawn_field" ] } Update the { "mapgen_update": "map_bridge", "om_terrain": "small_pond", "key": "as_soon_as_this_event_trigger" } Update the {
"mapgen_update": "nest_ancilla_bar_place_BEMs",
"om_terrain": "robofachq_subcc_a2",
"target_var": { "global_val": "ancilla_bar_loc" }
}
|
Syntax | Optionality | Value | Info |
---|---|---|---|
"revert_location" | mandatory | variable object | id of variable, where the location would be stored |
"time_in_future" | mandatory | int, duration, variable object) or value between two | when the location should be reverted; "infinity" could be used, to make location not update until key event happen |
"key" | optional | string or variable objects | id of the event, that you can call outside of EoC to trigger location reverse. Key should be alter_timed_events |
Examples
Store vitrified_farm_ground
. When vitrified_farm_escape_key
is called, the location is reverted
{
"revert_location": { "global_val": "vitrified_farm_ground" },
"time_in_future": "infinite",
"key": "vitrified_farm_escape_key"
},
Anyway we should probably add a comment that this could be potentially fixed in a similar fashion to what is used elsewhere ie the vitrified farm.
How about moving them to "Crazy Cataclysm"? They would seem to fit there.
|
Crazy Cataclysm is Kevin's mod that he manages what goes in it. If he decides to add this there he will do so. |
Summary
Mods "[Magiclysm] Stop workshop elves and their workshop from spawning"
Purpose of change
The original intention with the elf workshop and its inhabitants as written in #46460 was that they were holiday monsters. However, there's currently no way to make locations holiday-only. That means that elf workshops are free anvils, since you can walk in, the elves all cower away from you, and you take the anvil and then move on rather than actually having to make a demon forge. That's less than ideal.
Describe the solution
Set elf workshops to 0 occurrences and also make them
GLOBALLY_UNIQUE
so they do not spawn until we have some way of making locations spawn only on holidays.Describe alternatives you've considered
Testing
Additional context
I'm also not a fan of them from a verisimilitude perspective, but the demon forge is the real offender. Once it's possible to have holiday locations they'd fit in just fine.